feat: RMQ context type + nestjs upgrade to v7.5.5 #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underfisk
changed the title
|
Closing in favor of #342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, there was request #350 that proposed to fix the
contextTypeto RMQ instead of relying on the defaulthttpavoiding null pointer exceptions.In fact that is true, when attempting to get anything from RMQ inside (lets say a guard) it will not return anything valid
Tested this change and it does not introduce any breaking changes and the Nestjs upgrade to v7 was required in order to have the newest features such as the
contextTypeChangelog:
rmqinstead of the defaulthttpNote
There are some temporary eslint disables that i hope after upgrading the majority of the packages to the most safe and recent version that we can tune them