Migrate to Nx monorepo #371

jeremylvln · 2022-01-21T14:19:43Z

This PR converts this Lerna monorepo to a Nx one. Closes #143.
Note: this PR is based on #342.

I've done no functional changes except lint fixes. I work with Nx every day, so I guess this implementation is somewhat ideal. Sorry for the large diff, a lot of files has been moved.

I've modified the CI accordingly, do not worry about the MansaGroup/nrwl-nx-action action used inside, I've created it :)

Tests are welcomed!

underfisk · 2022-01-22T18:26:15Z

@IamBlueSlime Thanks a bunch for doing this, our priority is getting v8 PR first and then this should be our next step

jeremylvln · 2022-01-22T18:27:56Z

@IamBlueSlime Thanks a bunch for doing this, our priority is getting v8 PR first and then this should be our next step

That's why this PR is rebased on the other one :D

WonderPanda · 2022-01-24T01:56:03Z

Wondering if it would be easier to just do a fresh migration over to NX now that the upgrade to Nest 8 is done. There's a huge number of duplicated commits and merge commits here that we don't really need.

jeremylvln · 2022-01-24T07:35:29Z

I will rebase the PR correctly asap

jeremylvln · 2022-01-24T09:48:24Z

Hi @WonderPanda, @underfisk. I've rebased the PR, I hope that I've not removed any commit during the process. As this PR moves a lot of file, pay attention to the modification of these file if I've missed something.

Btw, I've removed the CI job name, thus the required checks will not be filled, this PR will need to be force merged by an administrator.

WonderPanda · 2022-01-24T12:56:25Z

packages/common/project.json

@@ -28,6 +28,19 @@
        "jestConfig": "packages/common/jest.config.js",
        "passWithNoTests": true
      }
+    },
+    "version": {
+      "executor": "@jscutlery/semver:version",


@IamBlueSlime Do you have experience working with these plugin before as part of your day job? Or are these being included based just on the discussion we were having in #143

Nope, I don't have any on these plugins, I just saw your discussion in the issue while doing this PR, so I've added them. But by reading their README's it seemed pretty accurate to our needs here :/

@IamBlueSlime Could you potentially give us some pro/cons of using this rather than other available plugins or ways you would achieve this? I haven used this plugin before but I'm kinda curious

Okay no worries, I'll want to do some tests to make sure that the release and changelog process is smooth before we merge this in but the plugins definitely look promising

@underfisk I never used Nx to publish packages, I'm afraid I can't give you any pro/cons about any package concerning publishing :/

packages/rabbitmq/src/lib/amqp/connection.ts

WonderPanda

I'm not interested right now in switching away from Yarn 1 and over to NPM so we should revert the package-lock.json and changes to the CI scripts.

In the future I'd be more open to considering PNPM but it should be as a different PR and not mixed in with the NX stuff

underfisk · 2022-01-28T19:26:18Z

I'm not interested right now in switching away from Yarn 1 and over to NPM so we should revert the package-lock.json and changes to the CI scripts.

In the future I'd be more open to considering PNPM but it should be as a different PR and not mixed in with the NX stuff

I agree, if we have to switch our package manager I would definitely advocate for PNPM but now on this scope, we should just aim to switch to Nx with the bare minimum of what we have, and then we can start thinking about what's next

underfisk · 2022-02-02T01:25:21Z

@IamBlueSlime Can we merge the latest changes, i think we should start considering having Nx asap, there are some stuff that we have pending that can actually leverage having this ecosystem

jeremylvln · 2022-02-02T09:11:22Z

@IamBlueSlime Can we merge the latest changes, i think we should start considering having Nx asap, there are some stuff that we have pending that can actually leverage having this ecosystem

Hi @underfisk! There is currently an issue with Nx that breaks JS reflection on build, see nrwl/nx#8784. I do not think that libraries are impacted, but only the apps that are build. In all cases, just to be sure, I think it would be preferable to wait until my PR on Nx is merged before merging this one.

But if you want me to rebase this PR and remove npm-related commits, I can totally do that :)

underfisk · 2022-02-02T13:16:35Z

@IamBlueSlime Can we merge the latest changes, i think we should start considering having Nx asap, there are some stuff that we have pending that can actually leverage having this ecosystem

Hi @underfisk! There is currently an issue with Nx that breaks JS reflection on build, see nrwl/nx#8784. I do not think that libraries are impacted, but only the apps that are build. In all cases, just to be sure, I think it would be preferable to wait until my PR on Nx is merged before merging this one.

But if you want me to rebase this PR and remove npm-related commits, I can totally do that :)

No rush, i've ran into a similar problem before, well at max you can override terser plugin with a custom nx webpack file but if they can include that officially it would be better

underfisk · 2022-03-08T13:40:07Z

@IamBlueSlime I've noticed that the Nx PR has been merged, any news so far if it is included in any of the latest versions?

underfisk · 2022-04-23T16:40:49Z

@IamBlueSlime Do you have any plans on having this? I believe we were close to merge this experience

jeremylvln · 2022-04-25T08:14:05Z

@IamBlueSlime Do you have any plans on having this? I believe we were close to merge this experience

Hey, sorry for the long time, I've been quite busy at work. I do not think I will have the time to work on this today, but maybe tomorrow or Wednesday. Is this okay for you?

jeremylvln marked this pull request as draft January 21, 2022 14:46

jeremylvln changed the title ~~Test~~ Migrate to Nx monorepo Jan 21, 2022

WonderPanda force-pushed the master branch from 8c33b02 to d0a2192 Compare January 23, 2022 00:49

jeremylvln and others added 22 commits January 24, 2022 10:38

feat: bump to Nest 8 major [breaking change]

afaebd1

test(rabbitmq): fix assertion syntax

120667e

fix(#348): assertQueueErrorHandler initial impl

bced190

chore: cleanup on some unused ci

b2f2435

fix: multiple nestjs packages installed

07bc703

fix: test dependency

9136b8b

fix: removed integration build

9698a1e

refactor: move to Nx workspace

4356a3b

chore: add nx script

caffbbe

ci: add fetch-depth to checkout

bc2273c

fix(testing): add jest to build types

503d809

chore(deps): add @types/lodash

a5d1496

chore(deps): add zod

9061743

test(hasura): fix fixture path

72d7f7c

style: fix lint

e311001

fix(rabbitmq-e2e): fix tsconfig

9a5264e

fix(rabbitmq): typings

06e7198

fix: add nest and rxjs as peer deps

9996f67

chore: set package versions

60c938c

chore: add meta to packages

dc98f75

chore(deps): pin graphql

c29bad2

chore: remove publish scripts

8a6433f

jeremylvln marked this pull request as ready for review January 24, 2022 09:45

chore: add publish and version tasks to projects

dc210b1

WonderPanda reviewed Jan 24, 2022

View reviewed changes

packages/rabbitmq/src/lib/amqp/connection.ts Show resolved Hide resolved

WonderPanda requested changes Jan 24, 2022

View reviewed changes

jeremylvln closed this by deleting the head repository May 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Nx monorepo #371

Migrate to Nx monorepo #371

jeremylvln commented Jan 21, 2022 •

edited by WonderPanda

Loading

underfisk commented Jan 22, 2022

jeremylvln commented Jan 22, 2022

WonderPanda commented Jan 24, 2022

jeremylvln commented Jan 24, 2022

jeremylvln commented Jan 24, 2022 •

edited

Loading

WonderPanda Jan 24, 2022

jeremylvln Jan 24, 2022

underfisk Jan 24, 2022

WonderPanda Jan 24, 2022

jeremylvln Jan 24, 2022

WonderPanda left a comment

underfisk commented Jan 28, 2022

underfisk commented Feb 2, 2022

jeremylvln commented Feb 2, 2022

underfisk commented Feb 2, 2022

underfisk commented Mar 8, 2022

underfisk commented Apr 23, 2022

jeremylvln commented Apr 25, 2022

Migrate to Nx monorepo #371

Migrate to Nx monorepo #371

Conversation

jeremylvln commented Jan 21, 2022 • edited by WonderPanda Loading

underfisk commented Jan 22, 2022

jeremylvln commented Jan 22, 2022

WonderPanda commented Jan 24, 2022

jeremylvln commented Jan 24, 2022

jeremylvln commented Jan 24, 2022 • edited Loading

WonderPanda Jan 24, 2022

Choose a reason for hiding this comment

jeremylvln Jan 24, 2022

Choose a reason for hiding this comment

underfisk Jan 24, 2022

Choose a reason for hiding this comment

WonderPanda Jan 24, 2022

Choose a reason for hiding this comment

jeremylvln Jan 24, 2022

Choose a reason for hiding this comment

WonderPanda left a comment

Choose a reason for hiding this comment

underfisk commented Jan 28, 2022

underfisk commented Feb 2, 2022

jeremylvln commented Feb 2, 2022

underfisk commented Feb 2, 2022

underfisk commented Mar 8, 2022

underfisk commented Apr 23, 2022

jeremylvln commented Apr 25, 2022

jeremylvln commented Jan 21, 2022 •

edited by WonderPanda

Loading

jeremylvln commented Jan 24, 2022 •

edited

Loading