Feat/659 unbound queues #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WonderPanda
requested changes
Nov 6, 2023
|
Should run green now! |
|
Just tried it out and spotted that I am missing the ability to bind it to an exchange like this. Gonna take another look on how to do that. |
|
@WonderPanda the queues are also bindable to an exchange with routing keys. I also already tested it locally! Would be glad about a review. |
|
@underfisk do you also have review & merge rights? |
Hi, i do have the review & merge rights. As soon as i have some free time i'll try to switch context and review the PR, meawhile i'll approve for CI to re-run |
underfisk
approved these changes
Nov 11, 2023
|
@fermentfan This should be available in Please try it out and let us know if its working for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces unbound queues to be added to the module definition like described in #659. I hope I found everything important :)