Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the Logger passed in RabbitMQModule config instead of default #663

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

lucas-gregoire
Copy link
Contributor

@lucas-gregoire lucas-gregoire commented Nov 17, 2023

Hello, I discovered an issue when passing a custom Logger to the RabbitMQModule:

image

Some logs are made using the logger passed in the config:

image
image

But some other logs, like ones written in onApplicationBootstrap, don't use the Logger provided in the config but the logger property of the RabbitMQModule which is not configurable.

image


So my fix consists of using the logger from the provided config everywhere in the RabbitMQModule.
And now all logs are correct:

image

@underfisk
Copy link
Contributor

@lucas-gregoire Thank you for the fix, LGTM i'll see if test passes and then have it merged

@underfisk underfisk enabled auto-merge (squash) November 18, 2023 21:08
@underfisk underfisk merged commit ec69e13 into golevelup:master Nov 18, 2023
3 checks passed
@lucas-gregoire lucas-gregoire deleted the fix/logger branch November 22, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants