Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wildcard topic matcher, support * and # in routingKeys #668

Closed
wants to merge 4 commits into from

Conversation

Dryymoon
Copy link

Thanks for a good library!

This fix add:

  • Support for amq.topic willcard routing key matching using '@artie-owlet/amqp-routing-match' lib

For example: message with routing key service.v1.log should match routing key service.v1.* and service.#

  • Fixed silently message looping when getting message with mismatching with defined routing key.

  • Fixed package.json mismatch

@Dryymoon Dryymoon changed the title feat: add topic mathcher from @artie-owlet/amqp-routing-match feat: add wildcard topic matcher, support * and # in routingKeys Dec 10, 2023
.gitignore Outdated Show resolved Hide resolved
@underfisk underfisk enabled auto-merge (squash) January 14, 2024 10:41
@underfisk
Copy link
Contributor

@Dryymoon Could you rebase?

@underfisk
Copy link
Contributor

@ttshivers If you have some free time and could help the buddy out, i can probably get this merged soon. I wish there was some test coverage as I've never used this library before, have you ever used it? Are there any cons of getting it merged using this library?

@ttshivers
Copy link
Contributor

ttshivers commented Jan 16, 2024

@ttshivers If you have some free time and could help the buddy out, i can probably get this merged soon. I wish there was some test coverage as I've never used this library before, have you ever used it? Are there any cons of getting it merged using this library?

I'm trying to understand the goal of this PR. Is this to double check that the message received on a queue matches the routing keys defined in code? Is the thought that there might be extra queue bindings defined on rabbitmq and we should do consumer verification and throw errors when we get unexpected messages?

@underfisk
Copy link
Contributor

I'm closing this PR, we'll re-open if we figure out that it is actually valuable. @ttshivers has left some interesting thoughts, i'd love to also understand a bit better this change

@underfisk underfisk closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants