feat(rabbitmq): publish using ChannelWrapper #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish messages using the ChannelWrapper instead of the raw ConfirmChannel to take advantage of the reliability features of `amqp-connection-manager`. BREAKING CHANGE: This changes the behavior of throwing connection related errors re golevelup#673
|
@ttshivers I love this change, reduces quite some boilerplate. My only concern is if this will work as intended for existing applications. If our test coverage is enough then I'm happy to include this as part of the next major with amq v4 |
|
I looked over the test coverage and it seems sufficient to ensure that messages are still getting published properly now using the channel wrapper instead. |
Alright, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish messages using the ChannelWrapper instead of the raw ConfirmChannel to take advantage of the reliability features of
amqp-connection-manager.BREAKING CHANGE: This changes the behavior of throwing connection related errors
re #673