Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): handle parallel RPCs response #711

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

farhadiis
Copy link
Contributor

Hello
There is a race condition between multiple RPCs in concurrency. This is obvious in distributed systems and happens when multiple RPCs use the same correlation id. To avoid this issue, using a request id that is defined in the request header will help.

@underfisk
Copy link
Contributor

@farhadiis Thank you for this change! Would it be valuable to add an example to our documentation on how to leverage X-Request-Id header as part of our module?
I do see value on driving awareness that such feature exist for this particular use case

@farhadiis
Copy link
Contributor Author

@underfisk Thanks for your hint. document updated.

@underfisk underfisk enabled auto-merge (squash) March 21, 2024 12:16
@underfisk underfisk merged commit bc86da9 into golevelup:master Mar 21, 2024
3 checks passed
Copy link

@shahrooz1981 shahrooz1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had the opportunity to review the changes made in this PR and I'm pleased to say that everything looks great to me. The code is clean, well-structured, and adheres to the project's standards.

One aspect that particularly stands out is the consideration for reverse compatibility. This is a crucial factor in maintaining the robustness of the software while ensuring that updates do not disrupt the functionality for existing users. The way this PR handles it is commendable.

I appreciate the effort put into this contribution. It's clear that this will positively impact the project. Keep up the good work!

WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
* feat(rpc): handle parallel RPCs response

* docs(rabbitmq): add in distributed systems
WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
* feat(rpc): handle parallel RPCs response

* docs(rabbitmq): add in distributed systems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants