Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(nestjs-graphql-request): bump graphql-request packages v7.0.1 #739

Conversation

GauthierD-
Copy link
Contributor

The package nestjs-graphql-request utilizes graphql-request, and a new version (v7.0.1) has been released. As a result of this major version update (v6 -> v7), I am also updating nestjs-graphql-request to v1.0.0.

Please be aware that this update includes breaking changes. The two primary changes are the discontinuation of support for CommonJS and the removal of the cross-fetch polyfill. A comprehensive list of the breaking changes can be found here:

https://github.com/jasonkuhrt/graphql-request/releases/tag/7.0.0

closes #738

the package nestjs-graphql-request use the graphql-request and there is a new version (v7.0.1)
available. Because of this new major version (v6 -> v7) I also bump the nestjs-graphql-request to
v1.0.0

BREAKING CHANGE: the 2 main breaking changes are the end of the support for CommonJS + remove
cross-fetch polyfill. The Breaking changes list:
https://github.com/jasonkuhrt/graphql-request/releases/tag/7.0.0

closes golevelup#738
@GauthierD- GauthierD- changed the title chore(graphql-request): bump graphql-request packages v7.0.1 chore(nestjs-graphql-request): bump graphql-request packages v7.0.1 May 21, 2024
@GauthierD-
Copy link
Contributor Author

Dunno why the CI fail, if someone has an idea feel free to share

On my local machine:
Screenshot 2024-05-21 at 7 37 38 PM
Screenshot 2024-05-21 at 7 37 45 PM

@underfisk
Copy link
Contributor

@GauthierD- Could you re-generate yarn.lock? It doesn't seem to be able to find graphql-request for some reason

@GauthierD-
Copy link
Contributor Author

Hello @underfisk I can now reproduce this error, I guess it's related to that =/

TypeScript Setup
This package uses [package.exports] (https://www.typescriptlang.org/docs/handbook/modules/reference.html#packagejson-exports). Therefore if you are a > TypeScript user you must:

have your tsconfig.json moduleResolution set to ["bundler"](https://www.typescriptlang.org/docs/handbook/modules/reference.html#bundler) or ["node16"/"nodenext"](https://www.typescriptlang.org/docs/handbook/modules/reference.html#node16-nodenext-1).
Have your package.json type set to "module".

I'll try something but I'm not an expert of Lerna wish me luck 🍀

@GauthierD-
Copy link
Contributor Author

GauthierD- commented Jun 4, 2024

I fixed the build but now the problem is related to jest (ts-jest) =/
I think I'll close this PR for now and if someone have time they can finish the job 👌

@GauthierD- GauthierD- closed this Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golevelup/nestjs-graphql-request: update dependencies graphql-request@7.0.1
2 participants