Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ts-sinon): fixed match all issue of jest mocks #752

Merged
merged 1 commit into from
Jun 28, 2024
Merged

fix(ts-sinon): fixed match all issue of jest mocks #752

merged 1 commit into from
Jun 28, 2024

Conversation

VonRehberg
Copy link
Contributor

This PR fixes issue #703

underfisk
underfisk approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@underfisk underfisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for this addition 🙏

@underfisk underfisk enabled auto-merge (squash) June 28, 2024 13:09
@underfisk underfisk merged commit 9e8fd47 into golevelup:master Jun 28, 2024
3 checks passed
@VonRehberg
Copy link
Contributor Author

Thanks for maintaining these tools and for merging!

I was considering to mark my commit as a breaking change instead of a patch.
In my opinion it fixes an issue, but it could cause a lot of tests to fail in packages using renovate. Please consider this when publishing to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfisk underfisk underfisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VonRehberg @underfisk