Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for HA 2024.1 #112

Merged
merged 3 commits into from
Jan 1, 2024
Merged

Fix for HA 2024.1 #112

merged 3 commits into from
Jan 1, 2024

Conversation

hmmbob
Copy link
Contributor

@hmmbob hmmbob commented Dec 31, 2023

Easy fix for the deprecated constants - works totally fine locally.

You are already pinning 2023.9 as lowest version, which means that all HA version that can currently install this integration have support for this (since 2023.1, so no breaking change).

Fixes #111

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8c686da) 95.58% compared to head (3627e5b) 95.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files           9        9           
  Lines         362      362           
=======================================
  Hits          346      346           
  Misses         16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@golles
Copy link
Owner

golles commented Dec 31, 2023

Thanks!
Tests have passed btw, but only uploading to SonarCloud has failed, no worries about the failing check!

@golles golles merged commit 8c23d06 into golles:main Jan 1, 2024
6 of 7 checks passed
@golles
Copy link
Owner

golles commented Jan 1, 2024

Thanks, again!

@hmmbob hmmbob deleted the patch-1 branch January 1, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecated constant in 2024.1
2 participants