Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hourly precipitation and add apparent temperature in weather entity #127

Conversation

golles
Copy link
Owner

@golles golles commented Feb 29, 2024

No description provided.

@golles golles linked an issue Feb 29, 2024 that may be closed by this pull request
1 task
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (8811bd2) to head (7110710).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   96.32%   96.35%   +0.03%     
==========================================
  Files           9        9              
  Lines         354      357       +3     
==========================================
+ Hits          341      344       +3     
  Misses         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -205,7 +211,7 @@ async def async_forecast_hourly(self) -> list[Forecast] | None:
self.coordinator.get_value(["uur_verw", i, "image"])
),
ATTR_FORECAST_TEMP: self.coordinator.get_value(["uur_verw", i, "temp"]),
ATTR_FORECAST_PRECIPITATION_PROBABILITY: self.coordinator.get_value(
ATTR_FORECAST_PRECIPITATION: self.coordinator.get_value(
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual fix for #126

Copy link

sonarcloud bot commented Mar 17, 2024

@golles golles merged commit 25b7489 into main Mar 17, 2024
8 checks passed
@golles golles deleted the 126-api-provides-hourly-neerslag-in-mm-yet-reported-incorrectly-in-ha-as branch March 17, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API provides hourly neerslag in mm, yet reported incorrectly in HA as %
1 participant