Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code smells #84

Merged
merged 3 commits into from
Jun 10, 2023
Merged

Fix code smells #84

merged 3 commits into from
Jun 10, 2023

Conversation

golles
Copy link
Owner

@golles golles commented Jun 10, 2023

Add Sonar Cloud extension/config

Add Sonar Cloud extension/config
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c1218ed) 95.10% compared to head (d23b45d) 95.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #84   +/-   ##
=======================================
  Coverage   95.10%   95.10%           
=======================================
  Files           9        9           
  Lines         327      327           
=======================================
  Hits          311      311           
  Misses         16       16           
Impacted Files Coverage Δ
custom_components/knmi/binary_sensor.py 97.01% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@golles golles marked this pull request as ready for review June 10, 2023 12:54
@golles golles merged commit 56952c5 into main Jun 10, 2023
@golles golles deleted the sonarcloud branch June 10, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant