Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2023.8.0 preps #88

Conversation

golles
Copy link
Owner

@golles golles commented Jul 29, 2023

  • Replace weather forecast with async_forecast_daily

  • Add dew point to weather entity (seems to be forgotten, but not visible in the default weather more-info dialog)

  • Rerun checks after HA 2023.8 release

- Replace weather `forecast` with `async_forecast_daily`
…s-overriding-deprecated-methods-on-an-instance-of-weatherentity-20238-beta
@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02% 🎉

Comparison is base (406358d) 95.10% compared to head (4b50e55) 95.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   95.10%   95.13%   +0.02%     
==========================================
  Files           9        9              
  Lines         327      329       +2     
==========================================
+ Hits          311      313       +2     
  Misses         16       16              
Files Changed Coverage Δ
custom_components/knmi/weather.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@golles golles merged commit 7e418f0 into main Aug 4, 2023
9 checks passed
@golles golles deleted the 87-custom_componentsknmiweatherknmiweather-is-overriding-deprecated-methods-on-an-instance-of-weatherentity-20238-beta branch August 4, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant