Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved log warning when a value is empty #97

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

golles
Copy link
Owner

@golles golles commented Sep 30, 2023

Will now log

Value d2tmin is empty in API response

Instead of trying to convert it, which logged:

Value d2tmin can't be converted to <class 'float'>

@golles golles linked an issue Sep 30, 2023 that may be closed by this pull request
1 task
@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (effcaba) 95.22% compared to head (a58c0a4) 95.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   95.22%   95.26%   +0.04%     
==========================================
  Files           9        9              
  Lines         335      338       +3     
==========================================
+ Hits          319      322       +3     
  Misses         16       16              
Files Coverage Δ
custom_components/knmi/coordinator.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@golles golles merged commit c56020d into main Oct 13, 2023
9 checks passed
@golles golles deleted the 96-value-d2tmin-cant-be-converted-to-class-float branch October 13, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value d2tmin can't be converted to <class 'float'>
1 participant