Adding YAML for a GH Action (try 2)

[arschles]

What is the problem I am trying to address?

None

How is the fix applied?

I added .github/workflows/go.yml to set up a basic GitHub action

Mention the issue number it fixes or add the details of the changes if it doesn't have a specific issue.

Ref #1460

[marwan-at-work]

@arschles actions are down lol https://www.githubstatus.com/

[arschles]

@marwan-at-work must be why all my previous PRs weren't running 😆

I just updated the branch and looks like the action just passed. Yesterday GH opened up actions to everyone, do you think we should put this on hold until they stabilize?

[marwan-at-work]

Probably, but also see if it provides any value that we are currently missing from our current CIs

[arschles]

@marwan-at-work there are a few things that overall make GH actions a nicer experience for me. Most of the below points are subjective though, so I hope this doesn't sound too much like a sales pitch. My biggest overall argument for GH actions is that they're right next to the PR so you don't need to authenticate with another service or deal with another interface.

• You can see the build logs, restart a build, etc... inside of the PR instead of going to drone/circle/etc... and logging in
• They're a bit more modular than what I've seen in drone or circle. We can have N workflows in different yaml files, which run in parallel. We can also split our steps up into separate docker containers if they end up getting big
• We can choose to run docker commands natively from scripts or run commands inside a container
• We can cache our dependencies. I know we could do it with circle, but not sure about drone?
• Scripts are already authenticated to GH and we can respond to tons of events
• We can do testing on windows VMs if we wanted to later (docs)

Let me know what you think. I'm totes cool if we stick with drone/circle/appveyor for a while or forever if people would rather

[marwan-at-work]

@arschles that's pretty cool, a couple things:

• I couldn't figure out how to restart a build from the link you sent me.
• Can we have background containers?

[arschles]

@marwan-at-work I have pressed a restart button before, I know it, but I can't find it at the moment. Maybe it was taken out. Anyway, that might be a problem for us if it's not there.

Yes, you can run background containers with docker run -d ...

[arschles]

Ah I see it on a different repo. There is a button called "re-run checks":

I'm wondering if it has to do with repo permissions. I'll need to investigate this more

[arschles]

@marwan-at-work I checked some other GH actions and my guess is that you can only restart checks if they failed. See here for a failure example

[DrPsychick]

closing as we have GitHub actions already merged: https://github.com/gomods/athens/tree/main/.github/workflows