Skip content length when it is not available in headers #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marwan-at-work
requested changes
Jun 18, 2021
linzhp
changed the title
linzhp
added a commit
to linzhp/athens
that referenced
this pull request
Aug 26, 2022
Summary: To pick up [[ gomods#1719 | gomods#1719 ]] and prepare for swithcing to S3 backend Test Plan: This will only be deployed after switching to S3 Reviewers: tanx JIRA Issues: GM-673 Differential Revision: https://code.uberinternal.com/D6215203
linzhp
added a commit
to linzhp/athens
that referenced
this pull request
Aug 26, 2022
Summary: To pick up [[ gomods#1719 | gomods#1719 ]] and prepare for switching to S3 backend Test Plan: This will only be deployed after switching to S3 Reviewers: tanx Reviewed By: tanx JIRA Issues: GM-673 Differential Revision: https://code.uberinternal.com/D6215203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
In some cases, Amazon S3 may not always return a Content-Length header. In this case, the size will not be set and take the zero value, and
http.ResponseWriterwill complain:The data will be ignored
How is the fix applied?
Skip
Content-Lengthin response when the size is 0, so at least the data can be sent.