Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WASM / WASI targets #69

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Wavesonics
Copy link

Apply new project hierarchy, remove deprecated targets, add new ones.

@Wavesonics Wavesonics changed the title New default proj New KMP targets Feb 12, 2024
@goncalossilva
Copy link
Owner

Thanks! This replaces #68, correct? I'll need to bring kotlinx-resources up-to-speed before this one.

@Wavesonics
Copy link
Author

yep it can replace it

@Wavesonics Wavesonics mentioned this pull request Feb 12, 2024
@goncalossilva goncalossilva changed the title New KMP targets Add WASM / WASI targets Apr 1, 2024
@Wavesonics
Copy link
Author

Any chance we could get this merged?

@goncalossilva
Copy link
Owner

@Wavesonics that's definitely the plan, but not before CI is green. kotlinx-resources does not yet support WASM/WASI so we have to either wait for support, or explicitly skip testing in these platforms (with a proper // TODO) until kotlinx-resources is ready.

@goncalossilva
Copy link
Owner

explicitly skip testing in these platforms (with a proper // TODO) until kotlinx-resources is ready

@Wavesonics is this something you're interested in contributing? We can merge right away once done. This way we don't need to block this update on kotlinx-resources, where WASM/WASI support might take a while.

@Wavesonics
Copy link
Author

ya I can do that

@Wavesonics
Copy link
Author

This looks like the only way to do it, did you have something else in mind?

@goncalossilva
Copy link
Owner

goncalossilva commented Jul 8, 2024

I was unaware of this aproach. :) I was thinking that we could leverage excludeTestsMatching from Gradle, e.g.:

// TODO: Not testing wasmJs until `kotlinx-resources` supports these targets.
tasks.named<Test>("wasmJsTest") {
    filter {
        excludeTestsMatching("*")
    }
}

// TODO: Not testing wasmWasi until `kotlinx-resources` supports these targets.
tasks.named<Test>("wasmWasiTest") {
    filter {
        excludeTestsMatching("*")
    }
}

(I didn't run this code; it might have typos or not run as is… I'm just aware of excludeTestsMatching)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants