-
Notifications
You must be signed in to change notification settings - Fork 11
Add Dpocon and tests #45
Conversation
This one at least matches Dgecon. No deterministic at the start because the matrix multiplied by itself is singular. |
if len(iwork) < n { | ||
panic(badWork) | ||
} | ||
clapack.Dpocon(uplo, n, a, lda, anorm, rcond) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing return.
LAPACKE seems to be pretty unhealthy. |
As a library or as something that works with Travis? |
Ah. Not good. This kind of thing makes me think we're the only ones who have tested a bunch of this interface ... I'd like to just say "disable the cgo test", but I'm more worried about that here since we actually plan on calling this function directly. The cgo tests also have the LQ factorizaton test commented out because of a bug. That's a significant chuck of Solve that won't work with a c-based lapack. I guess the answer is to make sure that the mat64 tests are robust, so the issues are visible on that level? I don't want to abandon clapack altogether because it's a useful check, but at the same time it's frustrating how many bugs we're finding (in such a widely used interface at that!) |
Indeed. I'm going to spend a little time on seeing if I can figure out why it's broken. I think we should disable the cgo test in the interim. |
Test disabled. |
Fix found. You will not believe it. |
Oh no! |
LGTM |
The cgo failures on my machine:
Do you want to send a PR to OpenBLAS for the fix you have? |
BTW What is the bug that's blocking Dormlq? |
I'm not sure what you mean by "The fix I have". The Go version just works, and I haven't been able to test this with cgo because of the openblas failures. LQ problem is OpenMathLib/OpenBLAS#615 |
Oh, sorry, conflating different threads (Dtrcon). |
No description provided.