Skip to content

Commit

Permalink
Silence remaining warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
gonzaponte committed Nov 12, 2024
1 parent c1c9d11 commit 3392acf
Show file tree
Hide file tree
Showing 19 changed files with 120 additions and 6 deletions.
13 changes: 13 additions & 0 deletions invisible_cities/cities/beersheba_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ def test_distribute_energy(ICDATADIR):
assert np.isclose (true_dst1.E.sum(), true_dst2.E.sum())


@ignore_warning.no_config_group
@ignore_warning.str_length
@ignore_warning.not_kdst
def test_beersheba_contains_all_tables(beersheba_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, "beersheba_contains_all_tables.h5")
Expand All @@ -73,6 +75,8 @@ def test_beersheba_contains_all_tables(beersheba_config, config_tmpdir):
assert node in h5out.root


@ignore_warning.no_config_group
@ignore_warning.str_length
@ignore_warning.not_kdst
@mark.parametrize("deco", DeconvolutionMode)
@mark.slow
Expand Down Expand Up @@ -104,6 +108,8 @@ def test_beersheba_exact_result( deco
assert_tables_equality(got, expected, rtol=1e-6)


@ignore_warning.no_config_group
@ignore_warning.str_length
@ignore_warning.not_kdst
@mark.slow
def test_beersheba_exact_result_with_satkill( ICDATADIR
Expand Down Expand Up @@ -146,6 +152,8 @@ def test_beersheba_only_ndim_2_is_valid(beersheba_config, ndim, config_tmpdir):
beersheba(**beersheba_config)


@ignore_warning.no_config_group
@ignore_warning.str_length
def test_beersheba_copies_kdst(beersheba_config, Th228_hits, config_tmpdir):
path_out = os.path.join(config_tmpdir, "beersheba_copies_kdst.h5")
beersheba_config.update(dict( file_out = path_out
Expand All @@ -158,6 +166,8 @@ def test_beersheba_copies_kdst(beersheba_config, Th228_hits, config_tmpdir):
assert expected_events == got_events


@ignore_warning.no_config_group
@ignore_warning.str_length
def test_beersheba_thresholds_hits(beersheba_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, "beersheba_thresholds_hits.h5")
threshold = 15 * units.pes
Expand All @@ -171,6 +181,8 @@ def test_beersheba_thresholds_hits(beersheba_config, config_tmpdir):
assert np.all(df.Q >= threshold)


@ignore_warning.no_config_group
@ignore_warning.str_length
def test_beersheba_filters_empty_dfs(beersheba_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, "beersheba_filters_empty_dfs.h5")
q_cut = 1e8 * units.pes
Expand All @@ -191,6 +203,7 @@ def test_beersheba_filters_empty_dfs(beersheba_config, config_tmpdir):

@ignore_warning.no_config_group
@ignore_warning.str_length
@ignore_warning.not_kdst
@ignore_warning.no_hits
def test_beersheba_does_not_crash_with_no_hits(beersheba_config, Th228_hits_missing, config_tmpdir):
path_out = os.path.join(config_tmpdir, "beersheba_does_not_crash_with_no_hits.h5")
Expand Down
3 changes: 3 additions & 0 deletions invisible_cities/cities/berenice_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@
from . berenice import berenice
from .. core.configure import configure
from .. core.testing_utils import assert_tables_equality
from .. core.testing_utils import ignore_warning
from .. types.symbols import all_events


@ignore_warning.no_config_group
def test_berenice_sipmdarkcurrent(config_tmpdir, ICDATADIR):
PATH_IN = os.path.join(ICDATADIR , 'sipmdarkcurrentdata.h5' )
PATH_OUT = os.path.join(config_tmpdir, 'sipmdarkcurrentdata_HIST.h5')
Expand Down Expand Up @@ -41,6 +43,7 @@ def test_berenice_sipmdarkcurrent(config_tmpdir, ICDATADIR):
assert np.all(ch_in_sipm == ch_out_sipm)


@ignore_warning.no_config_group
def test_berenice_exact_result(ICDATADIR, output_tmpdir):
file_in = os.path.join(ICDATADIR , "sipmdarkcurrentdata.h5")
file_out = os.path.join(output_tmpdir, "exact_result_berenice.h5")
Expand Down
4 changes: 4 additions & 0 deletions invisible_cities/cities/buffy_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,14 @@
from .. core import system_of_units as units
from .. core .configure import configure
from .. core .testing_utils import assert_tables_equality
from .. core .testing_utils import ignore_warning
from .. database import load_db
from .. io .mcinfo_io import load_mcsensor_response_df

from . buffy import buffy


@ignore_warning.no_config_group
def test_buffy_kr(config_tmpdir, full_sim_file):
file_in = full_sim_file
file_out = os.path.join(config_tmpdir, 'Kr_fullsim.buffers.h5')
Expand Down Expand Up @@ -156,6 +158,7 @@ def test_buffy_empty_file(config_tmpdir, ICDATADIR, fn_first, fn_second):
buffy(**conf)


@ignore_warning.no_config_group
def test_buffy_exact_result(config_tmpdir, ICDATADIR):
np.random.seed(27)

Expand All @@ -182,6 +185,7 @@ def test_buffy_exact_result(config_tmpdir, ICDATADIR):
assert_tables_equality(got, expected)


@ignore_warning.no_config_group
def test_buffy_splits_event(config_tmpdir, ICDATADIR):
file_in = os.path.join(ICDATADIR ,
'nexus_new_kr83m_full.newformat.sim.h5')
Expand Down
1 change: 1 addition & 0 deletions invisible_cities/cities/cities_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ def test_city_output_contains_configuration(config_tmpdir, city):
assert len(table[:]) > 0


@ignore_warning.no_config_group
def test_cities_carry_on_configuration_from_previous_ones(ICDATADIR, config_tmpdir):
rwf_file = os.path.join( ICDATADIR, "electrons_40keV_ACTIVE_10evts_RWF.h5")
pmaps_file = os.path.join(config_tmpdir, f"test_cities_carry_on_configuration_pmaps.h5")
Expand Down
2 changes: 2 additions & 0 deletions invisible_cities/cities/components_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ def write_config_file(filename, **kwargs):
, ["electrons_511keV_z250_RWF.h5" , "electrons_1250keV_z250_RWF.h5", "electrons_2500keV_z250_RWF.h5"] )
)
)
@ignore_warning.no_config_group
@ignore_warning.repeated_files
def test_city_files_in(case_, files_in, expected, config_tmpdir, ICDATADIR):
"""
Expand Down Expand Up @@ -163,6 +164,7 @@ def dummy_city( files_in : Union[str, list]
assert sorted(result) == sorted(expected)


@ignore_warning.no_config_group
@mark.parametrize("order", ((0,1), (1,0)))
def test_city_keeps_input_file_ordering(ICDATADIR, config_tmpdir, order):
files_in = [ os.path.join(ICDATADIR, "electrons_511keV_z250_RWF.h5")
Expand Down
13 changes: 12 additions & 1 deletion invisible_cities/cities/detsim_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
from .. io.dst_io import load_dst
from .. types.symbols import all_events
from .. core.testing_utils import assert_tables_equality
from .. core.testing_utils import ignore_warning


@ignore_warning.no_config_group
def test_detsim_contains_all_tables(ICDATADIR, output_tmpdir):

PATH_IN = os.path.join(ICDATADIR , "nexus_new_kr83m_fast.newformat.sim.h5")
Expand Down Expand Up @@ -40,6 +41,8 @@ def test_detsim_contains_all_tables(ICDATADIR, output_tmpdir):
assert sipmrd.shape == (1, 1792, n_sipm)


@ignore_warning.no_config_group
@ignore_warning.delayed_hits
def test_detsim_filter_active_hits(ICDATADIR, output_tmpdir):
# the first event in test file labels are set to NO_ACTIVE
PATH_IN = os.path.join(ICDATADIR , "nexus_new_kr83m_fast.newformat.sim.noactive.h5")
Expand All @@ -58,6 +61,8 @@ def test_detsim_filter_active_hits(ICDATADIR, output_tmpdir):
np.testing.assert_array_equal(filters["passed"], [False, True])


@ignore_warning.no_config_group
@ignore_warning.delayed_hits
def test_detsim_filter_dark_events(ICDATADIR, output_tmpdir):
# this file contains delayed hits that are filtered out
# leaving a very low energy hit that does not produce electrons
Expand All @@ -80,6 +85,7 @@ def test_detsim_filter_dark_events(ICDATADIR, output_tmpdir):
np.testing.assert_array_equal(filters["passed"], [False])


@ignore_warning.no_config_group
def test_detsim_filter_empty_waveforms(ICDATADIR, output_tmpdir):
# the first event radius is slighty above NEW active radius of 208.0 mm
PATH_IN = os.path.join(ICDATADIR, "nexus_new_kr83m_fast.newformat.sim.emptywfs.h5")
Expand All @@ -101,6 +107,7 @@ def test_detsim_filter_empty_waveforms(ICDATADIR, output_tmpdir):
np.testing.assert_array_equal(filters["passed"], [False, True])


@ignore_warning.no_config_group
def test_detsim_empty_input_file(ICDATADIR, output_tmpdir):

PATH_IN = os.path.join(ICDATADIR , "empty_mcfile.h5")
Expand All @@ -115,6 +122,7 @@ def test_detsim_empty_input_file(ICDATADIR, output_tmpdir):
assert result.evtnum_list == []


@ignore_warning.no_config_group
def test_detsim_exact(ICDATADIR, output_tmpdir):

PATH_IN = os.path.join(ICDATADIR , "nexus_new_kr83m_fast.newformat.sim.h5")
Expand Down Expand Up @@ -149,6 +157,7 @@ def test_detsim_exact(ICDATADIR, output_tmpdir):
assert_tables_equality(got, expected)


@ignore_warning.no_config_group
def test_detsim_exact_time_translation(ICDATADIR, output_tmpdir):

PATH_IN = os.path.join(ICDATADIR , "nexus_new_kr83m_fast.newformat.sim.h5")
Expand Down Expand Up @@ -190,6 +199,7 @@ def test_detsim_exact_time_translation(ICDATADIR, output_tmpdir):
assert_tables_equality(got, expected)


@ignore_warning.no_config_group
def test_detsim_buffer_times(ICDATADIR, output_tmpdir):
"""This test checks that the signal is properly placed in the buffer.
In particular:
Expand Down Expand Up @@ -263,6 +273,7 @@ def test_detsim_buffer_times(ICDATADIR, output_tmpdir):
assert tend == np.floor(s2_tmax / buffer_params["sipm_width"]) * buffer_params["sipm_width"]


@ignore_warning.no_config_group
def test_detsim_hits_without_strings(ICDATADIR, output_tmpdir):
PATH_IN = os.path.join(ICDATADIR , "nexus_next100_nostrings.h5")
PATH_OUT = os.path.join(output_tmpdir, "detsim_nostrings.h5")
Expand Down
9 changes: 8 additions & 1 deletion invisible_cities/cities/diomira_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from .. core.configure import configure
from .. core.testing_utils import assert_dataframes_close
from .. core.testing_utils import assert_tables_equality
from .. core.testing_utils import ignore_warning
from .. database import load_db

from .. io .mcinfo_io import get_event_numbers_in_file
Expand Down Expand Up @@ -46,6 +47,7 @@ def test_diomira_identify_bug(ICDATADIR):
assert np.sum(pmtwf[i]) == 0


@ignore_warning.no_config_group
@mark.slow
def test_diomira_copy_mc_and_offset(ICDATADIR, config_tmpdir):
PATH_IN = os.path.join(ICDATADIR , 'electrons_40keV_z250_MCRD.h5')
Expand Down Expand Up @@ -82,6 +84,7 @@ def test_diomira_copy_mc_and_offset(ICDATADIR, config_tmpdir):
hits_out )


@ignore_warning.no_config_group
@mark.slow
def test_diomira_mismatch_between_input_and_database(ICDATADIR, output_tmpdir):
file_in = os.path.join(ICDATADIR , 'electrons_40keV_z250_MCRD.h5')
Expand Down Expand Up @@ -125,6 +128,8 @@ def test_diomira_trigger_on_masked_pmt_raises_ValueError(ICDATADIR, output_tmpdi
with raises(ValueError):
diomira(**conf)


@ignore_warning.no_config_group
def test_diomira_read_multiple_files(ICDATADIR, output_tmpdir):
file_in = os.path.join(ICDATADIR ,
"Kr83_nexus_v5_03_00_ACTIVE_7bar_3evts*.MCRD.h5")
Expand Down Expand Up @@ -164,6 +169,7 @@ def test_diomira_read_multiple_files(ICDATADIR, output_tmpdir):
assert_dataframes_close(all_particle_in, particles_out)


@ignore_warning.no_config_group
def test_diomira_exact_result(ICDATADIR, output_tmpdir):
file_in = os.path.join(ICDATADIR ,
"Kr83_nexus_v5_03_00_ACTIVE_7bar_3evts.MCRD.h5")
Expand Down Expand Up @@ -197,6 +203,7 @@ def test_diomira_exact_result(ICDATADIR, output_tmpdir):
assert_tables_equality(got, expected)


@ignore_warning.no_config_group
def test_diomira_can_fix_random_seed(output_tmpdir):
file_out = os.path.join(output_tmpdir, "exact_result_diomira.h5")

Expand Down Expand Up @@ -227,7 +234,7 @@ def test_diomira_reproduces_singlepe(ICDATADIR, output_tmpdir):
pmt_gain = load_db.DataPMT('new', run_no).adc_to_pes.values
with tb.open_file(file_out) as h5saved:
pmt_sum_adc = np.sum(h5saved.root.RD.pmtblr, axis=2)

bins = np.arange(-50, 50, 0.5)
bin_centres = np.repeat(shift_to_bin_centers(bins)[np.newaxis, :],
len(pmt_gain), 0)
Expand Down
6 changes: 6 additions & 0 deletions invisible_cities/cities/dorothea_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,15 @@
from .. io.dst_io import load_dst
from .. core.testing_utils import assert_dataframes_close
from .. core.testing_utils import assert_tables_equality
from .. core.testing_utils import ignore_warning
from .. core.configure import configure
from .. core.system_of_units import pes, mm, mus, ns
from .. types.symbols import all_events

from . dorothea import dorothea


@ignore_warning.no_config_group
def test_dorothea_KrMC(config_tmpdir, KrMC_pmaps_filename, KrMC_kdst):
# NB: avoid taking defaults for PATH_IN and PATH_OUT
# since they are in general test-specific
Expand Down Expand Up @@ -48,6 +50,7 @@ def test_dorothea_KrMC(config_tmpdir, KrMC_pmaps_filename, KrMC_kdst):
assert_dataframes_close(dst, df_true, check_dtype=False, rtol=1e-2)


@ignore_warning.no_config_group
def test_dorothea_filter_events(config_tmpdir, Kr_pmaps_run4628_filename):
PATH_IN = Kr_pmaps_run4628_filename

Expand Down Expand Up @@ -103,6 +106,7 @@ def test_dorothea_filter_events(config_tmpdir, Kr_pmaps_run4628_filename):
assert np.all(dst.s2_peak.values == s2_peak_pass)


@ignore_warning.no_config_group
@mark.parametrize("include_mc", (False, True))
def test_dorothea_contains_all_tables(ICDATADIR, output_tmpdir, include_mc):

Expand Down Expand Up @@ -132,6 +136,7 @@ def test_dorothea_contains_all_tables(ICDATADIR, output_tmpdir, include_mc):
assert not ("MC/particles" in h5out.root) ^ include_mc


@ignore_warning.no_config_group
@mark.parametrize("include_mc", (False, True))
def test_dorothea_exact_result(ICDATADIR, output_tmpdir, include_mc):
tables = ("DST/Events", "Filters/s12_selector", "Run/events", "Run/runInfo")
Expand Down Expand Up @@ -159,6 +164,7 @@ def test_dorothea_exact_result(ICDATADIR, output_tmpdir, include_mc):
assert_tables_equality(got, expected)


@ignore_warning.no_config_group
def test_dorothea_empty_input_file(config_tmpdir, ICDATADIR):
# Dorothea must run on an empty file without raising any exception
# The input file has the complete structure of a PMAP but no events.
Expand Down
10 changes: 10 additions & 0 deletions invisible_cities/cities/esmeralda_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from .. core.testing_utils import ignore_warning


@ignore_warning.no_config_group
def test_esmeralda_runs(esmeralda_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, 'esmeralda_runs.h5')
nevt_req = 1
Expand All @@ -22,6 +23,7 @@ def test_esmeralda_runs(esmeralda_config, config_tmpdir):
assert cnt.events_in == nevt_req


@ignore_warning.no_config_group
def test_esmeralda_contains_all_tables(esmeralda_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, 'esmeralda_contains_all_tables.h5')
nevt_req = 1
Expand All @@ -43,6 +45,7 @@ def test_esmeralda_contains_all_tables(esmeralda_config, config_tmpdir):
assert node in h5out.root


@ignore_warning.no_config_group
def test_esmeralda_thresholds_hits(esmeralda_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_thresholds_hits.h5")
threshold = 50 * units.pes
Expand All @@ -56,6 +59,7 @@ def test_esmeralda_thresholds_hits(esmeralda_config, config_tmpdir):
assert np.all(df.Q >= threshold)


@ignore_warning.no_config_group
def test_esmeralda_drops_external_hits(esmeralda_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_drops_external_hits.h5")
fiducial_r = 450 * units.mm;
Expand All @@ -69,6 +73,7 @@ def test_esmeralda_drops_external_hits(esmeralda_config, config_tmpdir):
assert np.all(df.X**2 + df.Y**2 <= fiducial_r**2)


@ignore_warning.no_config_group
def test_esmeralda_filters_events_threshold(esmeralda_config, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_filters_events_threshold.h5")
esmeralda_config.update(dict( file_out = path_out
Expand Down Expand Up @@ -97,6 +102,7 @@ def test_esmeralda_filters_events_threshold(esmeralda_config, config_tmpdir):
assert df_events .evt_number.drop_duplicates().tolist() == evt_all


@ignore_warning.no_config_group
def test_esmeralda_exact_result(esmeralda_config, Th228_tracks, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_exact_result.h5")
esmeralda_config["file_out"] = path_out
Expand All @@ -121,6 +127,7 @@ def test_esmeralda_exact_result(esmeralda_config, Th228_tracks, config_tmpdir):


#if the first analyzed events has no overlap in blob buggy esmeralda will cast all overlap energy to integers
@ignore_warning.no_config_group
def test_esmeralda_blob_overlap_float_dtype(esmeralda_config, Th228_tracks, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_blob_overlap_float_dtype.h5")

Expand All @@ -133,6 +140,7 @@ def test_esmeralda_blob_overlap_float_dtype(esmeralda_config, Th228_tracks, conf
assert tracks.ovlp_blob_energy.dtype == float


@ignore_warning.no_config_group
def test_esmeralda_tracks_have_correct_number_of_hits(esmeralda_config, Th228_tracks, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_summary_gives_correct_number_of_hits.h5")
nevt_req = 3
Expand All @@ -150,6 +158,7 @@ def test_esmeralda_tracks_have_correct_number_of_hits(esmeralda_config, Th228_tr
assert sum(track.numb_of_hits) == len(ev_phits)


@ignore_warning.no_config_group
def test_esmeralda_all_hits_after_drop_voxels(esmeralda_config, Th228_hits, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_all_hits_after_drop_voxels.h5")
nevt_req = 2
Expand Down Expand Up @@ -177,6 +186,7 @@ def test_esmeralda_all_hits_after_drop_voxels(esmeralda_config, Th228_hits, conf


#TODO: refactor paolina to include this as a filter
@ignore_warning.no_config_group
def test_esmeralda_filters_events_with_too_many_hits(esmeralda_config, Th228_tracks, config_tmpdir):
path_out = os.path.join(config_tmpdir, "esmeralda_filters_events_with_too_many_hits.h5")
nevt_req = 2
Expand Down
Loading

0 comments on commit 3392acf

Please sign in to comment.