Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: saving/loading trie from disk #10

Closed
gonzedge opened this issue Jan 7, 2017 · 1 comment
Closed

Feature request: saving/loading trie from disk #10

gonzedge opened this issue Jan 7, 2017 · 1 comment
Labels
feature-request performance usability
Milestone
1.0.0

Comments

@gonzedge
Copy link
Owner

gonzedge commented Jan 7, 2017 •
edited
Loading

Also suggested by @darkogj
@darkogj
Copy link

darkogj commented Jan 7, 2017

The initial parsing from words to the trie tree takes pretty long time for every Ruby trie lib I've seen, any any efforts to mitigate this by saving/loading from disk would be big improvement imo.

gonzedge added a commit that referenced this issue Jan 8, 2017
@gonzedge
Add ability to serialize trie to disk!
db9efa1 
This can now be done by calling:

```
Rambling::Trie.dump your_trie, filename: 'a filename'
```

Then, later on:

```
trie = Rambling::Trie.load 'a filename'
```

Formats include Marshal and YAML!

[Related to #10]
gonzedge added a commit that referenced this issue Jan 8, 2017
@gonzedge
Make load/dump signatures consistent with each other
f1fcdea 
This can now be done by calling:

```
Rambling::Trie.dump your_trie, 'a filename'
```

Then, later on:

```
trie = Rambling::Trie.load 'a filename'
```

[Related to #10]
gonzedge added a commit that referenced this issue Jan 8, 2017
@gonzedge
Move serializers into own module
85a7608 
[Related to #10]
gonzedge added a commit that referenced this issue Jan 8, 2017
@gonzedge
Add #== to compare nodes
428cd33 
Two nodes are equal to each other if they have the same letter and their
children tree is the same

[In service of #10]
gonzedge added a commit that referenced this issue Jan 8, 2017
@gonzedge
Add tests for serializers
230fb09 
Extract new File serializer for common load/dump functionality.

[Related to #10]
gonzedge added a commit that referenced this issue Jan 8, 2017
@gonzedge
Document serialization process on README
33693ca 
[Closes #10]
gonzedge added a commit that referenced this issue Jan 9, 2017
@gonzedge
Extract configuration objects!
5de5b2f 
- Remove serializers and readers logic from Rambling::Trie module
- Add Configuration module
- Add Configuration::Properties module
- Unify readers and serializers configuration in Configuration::ProviderCollection
- Ensure tests use new configuration options appropriately

[Related to #10]
@gonzedge gonzedge modified the milestone: 1.0.0 Jan 9, 2017
gonzedge added a commit that referenced this issue Jan 11, 2017
@gonzedge
Add serialization benchmarks
0a42e49 
[Related to #10]
gonzedge added a commit that referenced this issue Feb 26, 2018
@gonzedge
Document serialization process on README
a18d0eb 
[Closes #10]
gonzedge added a commit that referenced this issue Feb 26, 2018
@gonzedge
Extract configuration objects!
02e7db2 
- Remove serializers and readers logic from Rambling::Trie module
- Add Configuration module
- Add Configuration::Properties module
- Unify readers and serializers configuration in Configuration::ProviderCollection
- Ensure tests use new configuration options appropriately

[Related to #10]
gonzedge added a commit that referenced this issue Feb 26, 2018
@gonzedge
Add serialization benchmarks
38799dd 
[Related to #10]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request performance usability
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@gonzedge @darkogj