Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop: upgrade and apply #24

Merged
merged 17 commits into from
May 4, 2023
Merged

Rubocop: upgrade and apply #24

merged 17 commits into from
May 4, 2023

Conversation

gonzedge
Copy link
Owner

@gonzedge gonzedge commented May 4, 2023

Issues found in lib/ and tasks/

  1. Explicitly disable Style/ExplicitBlockArgument due to performance hits (0a6aec0)
  2. Add missing supers
  3. Yoda-style conditionals
  4. Bump target ruby required version to current min supported (2.7.0)

Issues found in spec/

  1. Use instance_double instead of double
  2. Split tests into single-assertion specs when parameterization is possible; disable otherwise
  3. Use let! instead of instance variables
  4. Remove duplicate test groups
  5. Use when at the start of context block descriptions
  6. Use described_class, subject in specs where possible
  7. Single-line before where possible

Other

  1. Explicitly add rubocop-performance, rubocop-rake, rubocop-rspec plugins
  2. Remove unused Rails rules
  3. Remove unused/deprecated RSpec/Layout/Style/Lint rules

@gonzedge gonzedge changed the title Rubocop Rubocop: upgrade and apply May 4, 2023
@codeclimate
Copy link

codeclimate bot commented May 4, 2023

Code Climate has analyzed commit 2ec263d and detected 0 issues on this pull request.

View more on Code Climate.

@gonzedge gonzedge merged commit 2848687 into master May 4, 2023
@gonzedge gonzedge deleted the rubocop branch May 4, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant