Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RSpec::Config's filter_run_when_matching #43

Merged
merged 4 commits into from
May 12, 2023
Merged

Conversation

gonzedge
Copy link
Owner

... instead of deprecated run_all_when_everything_filtered. Also:

  • Use non-reserved words for file format and method name so that we are not accidentally shadowing important built-ins (:format => :file_format, :method => :method_name)
  • Explicitly assert any new Node is not a #word? by default after initialization
  • Remove unnecessary parens from let definitions in specs

gonzedge added 4 commits May 11, 2023 21:24
... instead of deprecated `run_all_when_everything_filtered`
So that we are not accidentally shadowing important built-ins:
- `:format` => `:file_format`
- `:method` => `:method_name`
@codeclimate
Copy link

codeclimate bot commented May 12, 2023

Code Climate has analyzed commit 0686e61 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@gonzedge gonzedge merged commit 57f5833 into master May 12, 2023
@gonzedge gonzedge deleted the spec-inspections branch May 12, 2023 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant