-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rbs types and corresponding lint check #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzedge
force-pushed
the
add-types
branch
4 times, most recently
from
February 20, 2024 03:27
4f9678b
to
d1a3936
Compare
Code Climate has analyzed commit 8001db0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (95% is the threshold). This pull request will bring the total coverage in the repository to 100.0% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First:
rbs
gem and allrbs
types insig/
directorysteep
gem for easier rbs type checking, with basic configuration only checkinglib
for nowrubyzip
types as they are not definedThen:
|| raise
for places where we expect to always have a value, but that rbs/steep are not smart enough to autodetectEMPTY_ENUMERATOR
to be returned when there is no iteration to perform_Nilable
interface to allow fornil?
check on generic type forProviderCollection#contains?
ProviderCollection#resolve
tokey?
check to prevent rbs/steep from complaining aboutCannot have body method
children_match_prefix
partial_word_chars?
word_chars?
closest_node
private abstract methods toNodes::Node
, so that bothNodes::Raw
andNodes::Compressed
have it without duplicationyardoc
matchrbs
typesFinally:
char_symbols
toreversed_char_symbols
for clarityNodes::Raw#add
's paramchars
toreversed_chars
for claritylint-rbs-steep
actionlint
=>lint-rubocop
3.3.6