Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rbs types and corresponding lint check #57

Merged
merged 35 commits into from
Nov 30, 2024
Merged

Add rbs types and corresponding lint check #57

merged 35 commits into from
Nov 30, 2024

Conversation

gonzedge
Copy link
Owner

@gonzedge gonzedge commented Jan 27, 2024

First:

  • Add rbs gem and all rbs types in sig/ directory
  • Add steep gem for easier rbs type checking, with basic configuration only checking lib for now
  • Add rubyzip types as they are not defined

Then:

  • Add || raise for places where we expect to always have a value, but that rbs/steep are not smart enough to autodetect
  • Add EMPTY_ENUMERATOR to be returned when there is no iteration to perform
  • Add _Nilable interface to allow for nil? check on generic type for ProviderCollection#contains?
  • Expand ProviderCollection#resolve to key? check to prevent rbs/steep from complaining about Cannot have body method
  • Add children_match_prefix partial_word_chars? word_chars? closest_node private abstract methods to Nodes::Node, so that both Nodes::Raw and Nodes::Compressed have it without duplication
  • Make yardoc match rbs types

Finally:

  • Rename char_symbols to reversed_char_symbols for clarity
  • Rename Nodes::Raw#add's param chars to reversed_chars for clarity
  • Add lint-rbs-steep action
  • Rename lint => lint-rubocop
  • Bump lint and coverage ruby versions to 3.3.6

@gonzedge gonzedge force-pushed the add-types branch 4 times, most recently from 4f9678b to d1a3936 Compare February 20, 2024 03:27
@gonzedge gonzedge changed the title Add rbs types Add rbs types and corresponding lint check Nov 30, 2024
@gonzedge gonzedge marked this pull request as ready for review November 30, 2024 02:04
Copy link

codeclimate bot commented Nov 30, 2024

Code Climate has analyzed commit 8001db0 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (95% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

@gonzedge gonzedge merged commit 692d20b into main Nov 30, 2024
27 checks passed
@gonzedge gonzedge deleted the add-types branch November 30, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant