Ensure only non-root nodes are marked as terminal #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonzedge
force-pushed
the
ensure-root-is-never-terminal
branch
from
9b59924 to
9cfbf75
Compare
gonzedge
added a commit
that referenced
this pull request
Feb 20, 2024
This bug was introduced by #63.
gonzedge
added a commit
that referenced
this pull request
Feb 20, 2024
This bug was introduced by #63.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out calling
#addwith an empty string in eitherContainerorNodes::Rawcurrently results in marking the root node as terminal, which is not the expected behavior. This PR fixes that by checkingroot?before callingterminal!.