Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show repeater column titles for measures #4913

Merged
1 commit merged into from
Apr 15, 2024
Merged

Conversation

kandl
Copy link
Contributor

@kandl kandl commented Apr 15, 2024

Do not remove simple measure titles for repeater,
as they can be transformed to inline measures for the execution, and then we don't have access to the original measure descriptor and title.

JIRA: F1-148


Important

Please, don't forget to run rush change for the commits that introduce new features 🙏


Refer to documentation to see how to run checks and tests in the pull request. This is the list of the most used commands:

extended test - backstop
extended test - tiger-cypress - integrated
extended test - tiger-cypress - isolated
extended test - tiger-cypress - record

@kandl kandl added ready to review PR is ready to final code review publish pre-release labels Apr 15, 2024
@ghost
Copy link

ghost commented Apr 15, 2024

Do not remove simple measure titles for repeater,
as they can be transformed to inline measures for the execution,
and then we don't have access to the original measure descriptor and title.

JIRA: F1-148
@ghost
Copy link

ghost commented Apr 15, 2024

Build in pipeline check aborted.

@ghost ghost removed the merge label Apr 15, 2024
@ghost ghost removed the merge label Apr 15, 2024
@ghost ghost merged commit a04f898 into gooddata:master Apr 15, 2024
1 of 3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
publish pre-release ready to review PR is ready to final code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants