Encoding generalizations #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodmami
requested changes
Aug 30, 2022
|
@BramVanroy changes are now published to PyPI in version 1.2.2. Cheers |
|
Thanks a lot for the quick responses and fast iteration! Also really appreciate the quick push to PyPi so I can readily start using it. Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, some issues may be experienced by Windows users because of encoding issues. The reason is that Windows unfortunately still relies on cp1252 rather than utf-8. This PR explicitly sets utf-8 where applicable (set-up files) and allows user-defined encoding elsewhere (in the
codecmodule as well as the command line script).Tests completed successfully.
Closes #109