Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: delete minor unreachable code caused by t.Fatal #1285

Merged
merged 1 commit into from
Aug 10, 2022
Merged

test: delete minor unreachable code caused by t.Fatal #1285

merged 1 commit into from
Aug 10, 2022

Conversation

Abirdcfly
Copy link
Contributor

Signed-off-by: Abirdcfly fp544037857@gmail.com

@Abirdcfly
delete minor unreachable code caused by t.Fatal
1be92e8 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>


Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@yangkaa
Copy link
Collaborator

yangkaa commented Aug 10, 2022

What problem is this to solve？

@Abirdcfly
Copy link
Contributor Author

What problem is this to solve？

The continue here means that the author thinks the loop can continue. But in fact it doesn't. So delete this false implication to avoid misunderstanding.

@yangkaa yangkaa changed the title delete minor unreachable code caused by t.Fatal test: delete minor unreachable code caused by t.Fatal Aug 10, 2022
yangkaa
yangkaa approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@yangkaa yangkaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yangkaa yangkaa merged commit 654f3f6 into goodrain:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangkaa yangkaa yangkaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @yangkaa