Respect already quoted collection name in column #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous you could not use a schema other than public and quoted collection names were being 'double quoted' in columns
| @@ -46,8 +46,12 @@ define(function(require, exports, module){ | |||
| return '"' + collection + '".' + field; | |||
|
|
|||
| // No collection, no quotes | |||
| else if (collection) | |||
| else if (collection) { | |||
| if(collection.indexOf('"') > -1) { | |||
There was a problem hiding this comment.
Two things - can you update the comment to reflect the situation (that's the biggest thing!) and while you're in there just put a darn space between that if and (
There was a problem hiding this comment.
no prob sorry i missed that
|
Also, thanks for the PR XOXOXOXO ❤️ |
|
Bam - updated. xoxo |
jrf0110
added a commit
that referenced
this pull request
Oct 22, 2013
Respect already quoted collection name in column
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous you could not use a schema other than public and
quoted collection names were being 'double quoted' in columns