Adjust test tolerances for test_assert_trees_all_close #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_612417869
branch
2 times, most recently
from
fc6be76
to
d89e04d
Compare
copybara-service
bot
force-pushed
the
test_612417869
branch
from
d89e04d
to
ce4558a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust test tolerances for test_assert_trees_all_close
The test for chexify
assert_trees_all_closeasserted thatjnp.isclose(10, 20, rtol=0.5, atol0.5)is false. By the rules ofnp.testing.assert_allclosethisshould actually pass, because (|10-20| <= 0.5 + (0.5 * 20)). However, it was only
when JAX PR #19936 was merged that this became the case.
This changes the rtol/atol to make the test pass.