Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for liars_poker #1127

Merged
merged 2 commits into from
Oct 19, 2023
Merged

bug fix for liars_poker #1127

merged 2 commits into from
Oct 19, 2023

Conversation

ciamac
Copy link
Contributor

@ciamac ciamac commented Oct 16, 2023

  • fixed actions game definition of liars_poker
  • regenerate tests

@google-cla
Copy link

google-cla bot commented Oct 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lanctot
Copy link
Collaborator

lanctot commented Oct 17, 2023

The failed wheels test is our fault from an update yesterday, we'll fix that. Apologies.

@lanctot
Copy link
Collaborator

lanctot commented Oct 17, 2023

The failed wheels test is our fault from an update yesterday, we'll fix that. Apologies.

Ok, fixed. Can you pull changes from master and push the merge commit to re-trigger the tests?

@lanctot lanctot added imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync. labels Oct 19, 2023
@lanctot lanctot merged commit a95a9d6 into google-deepmind:master Oct 19, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported This PR has been imported and awaiting internal review. Please avoid any more local changes, thanks! merged internally The code is now submitted to our internal repo and will be merged in the next github sync.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants