Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import metrics python3 compatible #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nozdi
Copy link

@Nozdi Nozdi commented Mar 16, 2019

Hey there,

I wanted to use your code to compute surface distance but one import was not python3 compatible.
Here is a PR which sorts out this issue.

Cheers

@ntomita
Copy link

ntomita commented Oct 12, 2019

Hi @derpson, this PR is important for those who use python3. I also confirmed this change works. Please review and merge this. Thanks!

@zzzzzzzzzzzzz
Copy link

Guys, please merge it. Faced the same issue, though fixed it manually

@SimonBiggs
Copy link

SimonBiggs commented Oct 19, 2019

We're planning on making use of this in an upcoming project, and we are interested in the long term maintenance of it. It appears that for the time being this package isn't a priority of Deepmind's (I mean they have buckets of other things, so who can blame them. I am grateful that it has been made open source).

Would others here be interested in having this library being made available on PyPI by being made available within the following PyPI package that I maintain (with this fix of course)?

A good location for it I believe would be alongside the DICOM structure tools:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants