Skip to content

Commit

Permalink
Disable pylint on test files until pylint-dev/pylint#9185 is fixed.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 628185025
  • Loading branch information
shaobohou authored and TF2JAXDev committed Apr 25, 2024
1 parent 2a504b3 commit b153ba1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ flake8 `find tf2jax -name '*.py' | xargs` --count --select=E9,F63,F7,F82,E225,E2
PYLINT_ARGS="-efail -wfail"
# Lint modules and tests separately.
python -m pylint --rcfile=.pylintrc `find tf2jax -name '*.py' | grep -v 'test.py' | xargs` || pylint-exit $PYLINT_ARGS $?

# Disable `protected-access` warnings for tests.
# Disable `unexpected-keyword-arg` and `no-value-for-parameter` error for tests due to false positives in tensorflow.
python -m pylint --rcfile=.pylintrc `find tf2jax -name '*_test.py' | xargs` -d W0212,E1123,E1120 || pylint-exit $PYLINT_ARGS $?
# TODO(shaobohou) Reenable after https://github.com/pylint-dev/pylint/issues/9185 is fixed.
# python -m pylint --rcfile=.pylintrc `find tf2jax -name '*_test.py' | xargs` -d W0212,E1123,E1120 || pylint-exit $PYLINT_ARGS $?

# Build the package.
python setup.py sdist
Expand Down

0 comments on commit b153ba1

Please sign in to comment.