This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Use ECMAScript 2015 modules #245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows lodash to be replaced with lodash-es for smaller builds.
|
Have you measured a size difference? The current build is already only requiring in the lodash functions it needs. |
|
I don't think it will make a difference, on our app we found that manually importing using the lodash/function pattern was the most efficient. |
|
I think the PR als has the benefit that it updates the code a bit, makes it a bit easier to read. I read in the code style guide that you prefer the old style, but maybe it is time to change this? |
|
I agree moving to modern syntax is good, I don't think you need to also move to lodash-es |
|
How is this PR not merged or denied by now? Is velocity-react not maintained anymore? |
Anyone with an answer to this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows lodash to be replaced with lodash-es for smaller builds.