-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure #131
Restructure #131
Conversation
- remove .DS_Store file - consolidate PaliGemma and PaliGemma_2 - Move complex end-to-end demo applications to "Demos" directory
- keep the main document simple - remove WISHLIST.md
- add README.md for Gemma and Workshops - modify partner-quickstarts
change the link to the folder instead of README.md
- CodeGemma, Demos, PaliGemma - add contents in Gemma/README.md
fix jar file path
remove unused labeler
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
exclude deleted file from nbfmt check
I've fixed all nbfmt and colab button mismatch issue. And I think we can ignore lint with "inclusive language" failed. |
working on a little more description on the table of notebooks |
add some description
Created 2 issues in wishlist label since we will remove "WISHLIST.md" with this restructure |
In a follow-up PR please let's fix the linting issues |
@philschmid could you take a look at this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would get rid of partner quickstart guides I think, they are a bit redundant with the gemma notebooks.
I'm still not 100% convinced by the naming. I feel it will bite us in the future, but in general the PR is good imo
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
It's failing with inclusive_language (native -> built-in) in the generated response examples like "Choctaw Native American tribe", so it's not possible to change.
It's failing with inclusive_language (native -> built-in) |
@@ -1,6 +1,10 @@ | |||
# Partner quickstart guides |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this file/directory
Gemma Cookbook Restructure