Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure #131

Merged
merged 39 commits into from
Feb 10, 2025
Merged

Restructure #131

merged 39 commits into from
Feb 10, 2025

Conversation

bebechien
Copy link
Collaborator

Gemma Cookbook Restructure

- remove .DS_Store file
- consolidate PaliGemma and PaliGemma_2
- Move complex end-to-end demo applications to "Demos" directory
- keep the main document simple
- remove WISHLIST.md
- add README.md for Gemma and Workshops
- modify partner-quickstarts
change the link to the folder instead of README.md
- CodeGemma, Demos, PaliGemma
- add contents in Gemma/README.md
fix jar file path
remove unused labeler
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bebechien bebechien changed the title Restructure [WIP] Restructure Jan 24, 2025
@bebechien
Copy link
Collaborator Author

I've fixed all nbfmt and colab button mismatch issue. And I think we can ignore lint with "inclusive language" failed.

windmaple
windmaple previously approved these changes Jan 24, 2025
@bebechien
Copy link
Collaborator Author

working on a little more description on the table of notebooks

@bebechien
Copy link
Collaborator Author

Created 2 issues in wishlist label since we will remove "WISHLIST.md" with this restructure

@bebechien bebechien changed the title [WIP] Restructure Restructure Jan 28, 2025
@osanseviero osanseviero self-requested a review January 29, 2025 08:57
@osanseviero
Copy link
Collaborator

In a follow-up PR please let's fix the linting issues

CodeGemma/README.md Outdated Show resolved Hide resolved
@osanseviero
Copy link
Collaborator

@philschmid could you take a look at this PR please?

Copy link
Collaborator

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would get rid of partner quickstart guides I think, they are a bit redundant with the gemma notebooks.

I'm still not 100% convinced by the naming. I feel it will bite us in the future, but in general the PR is good imo

CodeGemma/README.md Outdated Show resolved Hide resolved
Demos/README.md Show resolved Hide resolved
Demos/README.md Outdated Show resolved Hide resolved
Demos/README.md Show resolved Hide resolved
bebechien and others added 3 commits February 10, 2025 17:30
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
Co-authored-by: Omar Sanseviero <osanseviero@gmail.com>
@bebechien
Copy link
Collaborator Author

In a follow-up PR please let's fix the linting issues

  1. Gemma/[Gemma_2]Using_with_LLM_Comparator.ipynb

It's failing with inclusive_language (native -> built-in) in the generated response examples like "Choctaw Native American tribe", so it's not possible to change.

  1. Gemma/[Gemma_2]Using_with_SGLang.ipynb

It's failing with inclusive_language (native -> built-in)
But SGLang's official document is using "Native APIs", so I think changing it is not accurate.

@@ -1,6 +1,10 @@
# Partner quickstart guides
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file/directory

@bebechien bebechien merged commit 1078787 into google-gemini:main Feb 10, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants