Add Integration Tests for Content Caching #171
Conversation
The getGenerativeModelFromCachedContent parameter `cache` was errantly wrapped in an object.
No display name yet.
| * Integration tests against live backend. | ||
| */ | ||
|
|
||
| describe("cacheContent", function () { |
There was a problem hiding this comment.
We only have positive test cases. Is it worth testing cases where we expect errors? For example, testing that we get an error if we pass an invalid cached content name with blank spaces, special characters, empty string, etc...
Example in Python SDK: https://github.com/google-gemini/generative-ai-python/pull/355/files#diff-e57945cd50529ced9f0b8aa12022ab5140a6c706d74ecfd05280778f707d3d36R161-R177
There was a problem hiding this comment.
Discussed this offline. There are some unit tests already for negative scenarios where we test the SDK behavior itself. I will work to add some purposely failing integration tests, too, but that shouldn't block this release.
| @@ -53,6 +53,7 @@ describe("GoogleAICacheManager", () => { | |||
| systemInstruction: "talk like a cat", | |||
| tools: [{ functionDeclarations: [{ name: "myFn" }] }], | |||
| toolConfig: { functionCallingConfig: {} }, | |||
| displayName: "a display name.", | |||
There was a problem hiding this comment.
If adding it to the call, you should probably add an expectation that it's been added to the body, otherwise no reason to add it here (other than to see there's no error). See the other requestBody expectations below.
There was a problem hiding this comment.
Updated:
- now tests that displayName is in the request.
- added model as a constant at the top of the test, and use the correct model name for launch. (I know it doesn't matter what the model name is, but it's good to be consistent.)
| @@ -49,9 +49,7 @@ async function run() { | |||
|
|
|||
There was a problem hiding this comment.
I guess can you add a TODO or reminder to update line 41 here with the new official model name along with where you're going to do it in the integration test?
There was a problem hiding this comment.
I just added it in at this point. Done!
Updates to the Content Caching feature in development.
Documentation PR is separate: #172