Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send API key in header instead of query param. #21

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Send API key in header instead of query param. #21

merged 2 commits into from
Dec 18, 2023

Conversation

hsubox76
Copy link
Collaborator

Matches other platform SDKs, keeps API key out of url.

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: be91bb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@google/generative-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is actually a lot better. Sorry for not pointing this out in the previous PR
LGTM!

@hsubox76 hsubox76 merged commit 54839f2 into main Dec 18, 2023
3 checks passed
@hsubox76 hsubox76 deleted the ch-apikey branch December 18, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants