-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix requestOptions in startChat #228
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Thanks for catching this - two things:
|
@hsubox76 I have rebased the branch. However, I can't get
The error remains after I run Perhaps you can merge this and run the changeset command instead? |
I think some files must be leftover after the rebase, it works fine for me on your fork. Anyway you can manually add the changeset file. If we do it in a separate PR it won't link to this PR properly. Create a file:
|
@hsubox76 I've added the changeset file |
Thanks for removing the Are you able to run |
@hsubox76 Done! |
I ran the integration tests locally as outside contributors don't have access to the API key secret - passed. Thanks for the contribution, merging! |
Fix #227
In PR #144, the
requestOptions
ofGenerativeModel
is renamed to_requestOptions
, but there's arequestOptions
type declaration on the class, so TypeScript didn't catch the miss use ofrequestOptions
instead of_requestOptions
in thestartChat
method.