Pull Imagen feature #285
Open
Pull Imagen feature #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
reviewed
Oct 18, 2024
hsubox76
reviewed
Oct 21, 2024
| @@ -448,6 +448,13 @@ export interface GenerateContentStreamResult { | |||
| stream: AsyncGenerator<EnhancedGenerateContentResponse>; | |||
| } | |||
|
|
|||
| // @public | |||
| export interface GeneratedImage { | |||
| // Warning: (ae-forgotten-export) The symbol "PredictServiceValueType" needs to be exported by the entry point index.d.ts | |||
There was a problem hiding this comment.
Check this file for comments telling you what's still missing in the exported types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I messed up the old branch after doing a merge. Create this new branch for us to keep reviewing.
I have resolved all comments except one from @hsubox76
The ...request will cause testing error like this, because original request has more parameters than
parameterscould accept. And in new predict api theparametersare not typed.AssertionError: expected { model: 'test_model', …(2) } to deeply equal { …(3) } + expected - actual "parameters": { "aspectRatio": "1:1" "compressionQuality": 12 "guidanceScale": 5 - "height": 1024 "language": "ko" "negativePrompt": "Not a dog" - "numberOfImages": 1 "outputMimeType": "image/png" - "prompt": "Create a cat" "safetyFilterLevel": "block_medium_and_above" "sampleCount": 1 "sampleImageSize": 1024 - "width": 512 } }Related to #276