Explicit Caching #355
Merged
Explicit Caching #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Add basic CURD support for caching *Remove INPUT_ONLY marked fields from CachedContent dataclass *Rename files 'cached_content*' -> 'caching*' *Update 'Create' method for explicit instantination of 'CachedContent' *Add a factory method to instatinate model with `CachedContent` as its context *blacken *Add tests Change-Id: I694545243efda467d6fd599beded0dc6679b727d
github-actions
bot
added
status:awaiting review
Change-Id: Ie41602621d99ddff6404c6708c7278e0da790652
If not provided, the name will be randomly generated Change-Id: Ib95fbafd3dfe098b43164d7ee4d6c2a84b0aae2e
Change-Id: I6c69c036e54d56d18ea60368fa0a1dcda2d315fd
Change-Id: I06676fad23895e3e1a6393baa938fc1f2df57d80
Change-Id: I6020df4e862a4f1d58462a4cd70876a8448293cf
…ve-ai-python into caching Change-Id: Id2b259fe4b2c91653bf5e4d5e883f556366d8676
Change-Id: I2f02d2421d7303f0309ec86f05d33c07332c03c1
Change-Id: Ic1cd4fc28f591794dc5fbff0647a00a77ea7f601
Change-Id: I2bade6b0099f12dd37a24fe26cfda1981c58fbc0
|
Passing with the preview build. |
|
Cool, Thnx! |
MarkDaoust
approved these changes
Jun 5, 2024
| return protos.CreateCachedContentRequest(cached_content=cached_content) | ||
|
|
||
| @classmethod | ||
| def create( |
There was a problem hiding this comment.
Didn't implement it, due to the following reason:
- Does it make sense to have async for cacheservice?
- Anyway, I'll submit it in a separate PR, just copy paste and async/await :)
|
This is passing unittests, and works in my end-to-end testing. Let's merge, and we can fix these comments in follow-on PRs. |
github-actions
bot
removed
the
status:awaiting review
|
Thanks for the review 🙌🏻 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I694545243efda467d6fd599beded0dc6679b727d
===DO NOT SUBMIT===
*Inital prototype for explicit caching
*Add basic CURD support for caching
*Remove
INPUT_ONLYmarked fields fromCachedContentdataclass*Rename files
cached_content*->caching**Update
createmethod for explicit instantination of 'CachedContent'*Add a factory method to instatinate model with
CachedContentas its context*blacken
*Add tests
*Rename
get_cached_content->get*Stroke out functional approach for
CachedContentCURD ops*Validate
namechecks forCachedContentcreation*Update repr for
GenerativeModelto include information about the model's context*Update docstrings
*Improve tests