Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: thread-safe discovery API setup (Issues#327) #582

Conversation

Sumeet213
Copy link
Contributor

Description of the change

Added threading support to FileServiceClient to make discovery_api thread-local.

Motivation

Fixes a threading issue where multiple threads could simultaneously access self._discovery_api, leading to bugs. Making discovery_api thread-local gives each thread its own instance.

Resolves: #327

Type of change

Bug fix

Checklist

Copy link

google-cla bot commented Oct 3, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Oct 3, 2024
@Sumeet213 Sumeet213 closed this Oct 3, 2024
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants