Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function calling support #116

Merged
merged 12 commits into from
Mar 26, 2024
Merged

Add function calling support #116

merged 12 commits into from
Mar 26, 2024

Conversation

andrewheard
Copy link
Collaborator

@andrewheard andrewheard commented Mar 11, 2024 •
edited
Loading

Added manual function calling support.

@andrewheard andrewheard mentioned this pull request Mar 12, 2024
Draft
paulb777
paulb777 reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments

Sources/GoogleAI/FunctionCalling.swift Show resolved Hide resolved
Sources/GoogleAI/GenerativeModel.swift Show resolved Hide resolved
@andrewheard andrewheard changed the title Add function calling prototype Add function calling support Mar 26, 2024
@andrewheard andrewheard marked this pull request as ready for review March 26, 2024 21:26
@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Mar 26, 2024
@andrewheard andrewheard requested a review from paulb777 March 26, 2024 21:26
paulb777
paulb777 approved these changes Mar 26, 2024
View reviewed changes
Sources/GoogleAI/FunctionCalling.swift Show resolved Hide resolved
Sources/GoogleAI/FunctionCalling.swift Show resolved Hide resolved
@andrewheard andrewheard merged commit f4a8808 into main Mar 26, 2024
9 checks passed
@andrewheard andrewheard deleted the ah/function-calling-prototype branch March 26, 2024 22:50
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Mar 26, 2024
@andrewheard andrewheard mentioned this pull request Mar 27, 2024
Merged
@paulb777 paulb777 restored the ah/function-calling-prototype branch April 2, 2024 22:04
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
@andrewheard
Add function calling support (google-gemini#116)
62a13f1
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
@andrewheard
Add function calling support (google-gemini#116)
48f2a60
SsomsakTH pushed a commit to SsomsakTH/generative-ai-swift that referenced this pull request Jun 21, 2024
@andrewheard
Add function calling support (google-gemini#116)
fed56f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncooke3 ncooke3 ncooke3 left review comments

@peterfriese peterfriese peterfriese left review comments

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewheard @paulb777 @peterfriese @ncooke3