Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update swift-markdown-ui reference. #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update swift-markdown-ui reference. #212

wants to merge 1 commit into from

Conversation

rismay
Copy link

@rismay rismay commented Dec 13, 2024

Description of the change

Updated swift-markdown-ui to avoid build error in examples.

Motivation

Opening the samples with Xcode 16 leads to a build error which requires the updating of this dependency.

Type of change

Choose one: Bug fix

Checklist

  • I have performed a self-review of my code.
  • I have added detailed comments to my code where applicable.
  • I have verified that my change does not break existing code.
  • My PR is based on the latest changes of the main branch (if unsure, please run git pull --rebase upstream main).
  • I am familiar with the Google Style Guide for the language I have coded in.
  • I have read through the Contributing Guide and signed the Contributor License Agreement.

@rismay
Update project.pbxproj
3ba65ae 
Updated swift-markdown-ui to avoid build error in examples.
@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Dec 13, 2024
peterfriese
peterfriese reviewed Dec 13, 2024
View reviewed changes
Copy link
Collaborator

@peterfriese peterfriese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour of removing the pin to the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterfriese peterfriese peterfriese left review comments

@paulb777 paulb777 Awaiting requested review from paulb777

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rismay @peterfriese