Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on build warnings #46

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fail on build warnings #46

merged 2 commits into from
Dec 13, 2023

Conversation

paulb777
Copy link
Collaborator

@paulb777 paulb777 commented Dec 13, 2023

Let's strive to keep the code warning-free

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Dec 13, 2023
@paulb777 paulb777 requested a review from ryanwilson December 13, 2023 00:52
@paulb777 paulb777 enabled auto-merge (squash) December 13, 2023 00:52
Copy link
Collaborator

@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@paulb777 paulb777 merged commit 4570087 into main Dec 13, 2023
7 checks passed
@paulb777 paulb777 deleted the pb-fail-on-warnings branch December 13, 2023 00:57
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants