Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for unknown enum values in responses #60

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

andrewheard
Copy link
Collaborator

Added tests to verify that new enum values will be decoded as unknown (rather than throwing decoding errors). Tests the following enums:

  • SafetySetting.HarmCategory
  • SafetyRating.HarmProbability
  • PromptFeedback.BlockReason
  • FinishReason

@github-actions github-actions bot added component:swift sdk Issue/PR related to Swift SDK status:awaiting review PR awaiting review from a maintainer labels Dec 13, 2023
@andrewheard andrewheard merged commit a9f807d into main Dec 13, 2023
7 checks passed
@andrewheard andrewheard deleted the ah/unknown-enum-tests branch December 13, 2023 20:43
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:swift sdk Issue/PR related to Swift SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants