Check for empty API_KEY in plist #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
component:swift sdk
peterfriese
approved these changes
Dec 15, 2023
github-actions
bot
removed
the
status:awaiting review
enefry
pushed a commit
to enefry/generative-ai-swift
that referenced
this pull request
Jan 10, 2024
* 'main' of https://github.com/google/generative-ai-swift: [Release] Increment `version` to `0.4.6` (google-gemini#86) Add image adapters and tests (google-gemini#80) use explicit python3 (google-gemini#81) Add support for non-streaming APIs on macOS 11 (google-gemini#84) Support model names prefixed with "models/" (google-gemini#73) Increment version to 0.4.4 for release (google-gemini#74) Check for empty API_KEY in plist (google-gemini#71)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Added a check for no api key value being present against the
API_KEYentry in the plist.Motivation
I ran into an issue where I was integrating the SDK within my own application. I copied the
APIKey.swiftenum file to my project & created theGenerativeAI-Info.plistfile with anAPI_KEYkey-value pair but forgot to copy my own api key against it in the plist. The app ran without producing any results for obvious reasons. I figured other users who merely run the Sample app may also run into the same issue wherein they forget to copy their own api key after creating it.Type of change
Bug fix
Checklist
git pull --rebase upstream main).