Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly formatted version rules #133

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

jphan32
Copy link
Contributor

@jphan32 jphan32 commented Jul 27, 2023

Related issue number

Description

Fix incorrectly formatted version rules.

  • Remove the .* at line18 numpy>=1.19.*

@jphan32 jphan32 changed the title Fix incorrectly formatted version rules #132 Fix incorrectly formatted version rules Jul 27, 2023
setup.py Outdated Show resolved Hide resolved
@jphan32
Copy link
Contributor Author

jphan32 commented Aug 12, 2023

Could someone please review my PR? Thank you.

@jphan32
Copy link
Contributor Author

jphan32 commented Aug 12, 2023

Hello maintainers,

I recently submitted a pull request and noticed that there was a build error during the review process. Upon inspecting the error message, it was related to the install_requires section in the setup.py file. Specifically, the error message was:

  × Getting requirements to build wheel did not run successfully.
  │ exit code: 1
  ╰─> [3 lines of output]
      error in torchsde setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; .* suffix can only be used with `==` or `!=` operators
          numpy>=1.19.*;python_version>='3.7'
               ~~~~~~~^
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: subprocess-exited-with-error

To address this, I updated the requirement string from numpy>=1.19.*;python_version>='3.7' to numpy>=1.19;python_version>='3.7' and committed the changes. However, the build test still seems to produce the same error message indicating the presence of the older code.

Could you please help me understand why this might be happening? Is there something I may have missed or another step I need to take to ensure the updates are reflected?

Thank you for your assistance!

@patrick-kidger patrick-kidger self-assigned this Aug 14, 2023
@patrick-kidger
Copy link
Collaborator

Ah, that's because it's pulling from the GitHub main branch to do a version check. Let me poke at that.

FWIW you may note that torchsde hasn't been touched in a couple of years; I'll try to get this PR merged, but I'd recommend Diffrax for new projects.

@lxuechen
Copy link
Collaborator

@patrick-kidger I enabled force push for you. Can you check if you can force merge?

@lxuechen lxuechen merged commit bfd4855 into google-research:master Aug 14, 2023
@lxuechen
Copy link
Collaborator

@patrick-kidger I enabled force push for you. Can you check if you can force merge?

Merged and thanks, @jphan32. Let me know what else I should help with.

@jphan32
Copy link
Contributor Author

jphan32 commented Aug 16, 2023

I've confirmed that my PR has been successfully merged into the master branch. Thank you. Also, I appreciate the introduction to Diffrax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants