-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrectly formatted version rules #133
Conversation
Could someone please review my PR? Thank you. |
Hello maintainers, I recently submitted a pull request and noticed that there was a build error during the review process. Upon inspecting the error message, it was related to the install_requires section in the setup.py file. Specifically, the error message was:
To address this, I updated the requirement string from numpy>=1.19.*;python_version>='3.7' to numpy>=1.19;python_version>='3.7' and committed the changes. However, the build test still seems to produce the same error message indicating the presence of the older code. Could you please help me understand why this might be happening? Is there something I may have missed or another step I need to take to ensure the updates are reflected? Thank you for your assistance! |
Ah, that's because it's pulling from the GitHub main branch to do a version check. Let me poke at that. FWIW you may note that torchsde hasn't been touched in a couple of years; I'll try to get this PR merged, but I'd recommend Diffrax for new projects. |
@patrick-kidger I enabled force push for you. Can you check if you can force merge? |
Merged and thanks, @jphan32. Let me know what else I should help with. |
I've confirmed that my PR has been successfully merged into the master branch. Thank you. Also, I appreciate the introduction to Diffrax. |
Related issue number
Description
Fix incorrectly formatted version rules.