Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #140

Merged
merged 8 commits into from
Sep 26, 2023
Merged

Fix CI #140

merged 8 commits into from
Sep 26, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Sep 26, 2023

Re the discussion on #137 (hey @vladmandic 👋), this PR attempts to modernize and fix the CI process to actually pass again.

Along the way, it:

  • drops support for EOL versions of Python (because Torch isn't being shipped for EOL versions either)
  • drops the Boltons dependency, which was used for a single LRU dictionary, in favor of about 10 lines of code to the same effect.

You can see this passing over at akx#1 😊

@akx
Copy link
Contributor Author

akx commented Sep 26, 2023

@patrick-kidger If you could approve running the workflows, that'd be grand 😄

@akx akx mentioned this pull request Sep 26, 2023
@akx
Copy link
Contributor Author

akx commented Sep 26, 2023

@patrick-kidger CI's showin' all green!

@patrick-kidger patrick-kidger self-requested a review September 26, 2023 18:23
@patrick-kidger patrick-kidger merged commit 7222329 into google-research:master Sep 26, 2023
5 checks passed
@patrick-kidger
Copy link
Collaborator

Hurrah! This LGTM. Thank you for fixing this up. Time for a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants