Remove deprecated constructor in DefaultVideoFrameProcessor.Factory

Remove deprecated factory constructor and replace all call instances of it. PiperOrigin-RevId: 525476062
google · Apr 24, 2023 · 6dcb018 · 6dcb018
1 parent 3bcdac9
commit 6dcb018
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 16 deletions.
diff --git a/.../com/google/android/exoplayer2/effect/DefaultVideoFrameProcessorImageFrameOutputTest.java b/.../com/google/android/exoplayer2/effect/DefaultVideoFrameProcessorImageFrameOutputTest.java
@@ -123,7 +123,7 @@ private VideoFrameProcessorTestRunner.Builder getDefaultFrameProcessorTestRunner
       String testId) {
     return new VideoFrameProcessorTestRunner.Builder()
         .setTestId(testId)
-        .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory())
+        .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory.Builder().build())
         .setIsInputTextureExternal(false)
         .setOnOutputFrameAvailableListener(
             unused -> checkNotNull(framesProduced).incrementAndGet());

diff --git a/...idTest/java/com/google/android/exoplayer2/effect/DefaultVideoFrameProcessorPixelTest.java b/...idTest/java/com/google/android/exoplayer2/effect/DefaultVideoFrameProcessorPixelTest.java
@@ -506,7 +506,7 @@ private VideoFrameProcessorTestRunner.Builder getDefaultFrameProcessorTestRunner
       String testId) {
     return new VideoFrameProcessorTestRunner.Builder()
         .setTestId(testId)
-        .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory())
+        .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory.Builder().build())
         .setVideoAssetPath(INPUT_SDR_MP4_ASSET_STRING);
   }
 

diff --git a/...com/google/android/exoplayer2/effect/DefaultVideoFrameProcessorVideoFrameReleaseTest.java b/...com/google/android/exoplayer2/effect/DefaultVideoFrameProcessorVideoFrameReleaseTest.java
@@ -292,7 +292,8 @@ private void processFramesToEndOfStream(
     CountDownLatch videoFrameProcessingEndedCountDownLatch = new CountDownLatch(1);
     defaultVideoFrameProcessor =
         checkNotNull(
-            new DefaultVideoFrameProcessor.Factory()
+            new DefaultVideoFrameProcessor.Factory.Builder()
+                .build()
                 .create(
                     getApplicationContext(),
                     ImmutableList.of((GlEffect) (context, useHdr) -> blankFrameProducer),

diff --git a/...effect/src/main/java/com/google/android/exoplayer2/effect/DefaultVideoFrameProcessor.java b/...effect/src/main/java/com/google/android/exoplayer2/effect/DefaultVideoFrameProcessor.java
@@ -141,18 +141,6 @@ private Factory(
       this.textureOutputListener = textureOutputListener;
     }
 
-    // TODO(276913828): Remove and change all calls to a builder.
-    /**
-     * @deprecated Use {@link DefaultVideoFrameProcessor.Factory.Builder} instead.
-     */
-    @Deprecated
-    public Factory() {
-      this(
-          /* enableColorTransfers= */ true,
-          GlObjectsProvider.DEFAULT,
-          /* textureOutputListener= */ null);
-    }
-
     /**
      * {@inheritDoc}
      *

diff --git a/...ava/com/google/android/exoplayer2/transformer/mh/ToneMapHdrToSdrUsingOpenGlPixelTest.java b/...ava/com/google/android/exoplayer2/transformer/mh/ToneMapHdrToSdrUsingOpenGlPixelTest.java
@@ -213,6 +213,6 @@ private VideoFrameProcessorTestRunner.Builder getDefaultFrameProcessorTestRunner
       String testId) {
     return new VideoFrameProcessorTestRunner.Builder()
         .setTestId(testId)
-        .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory());
+        .setVideoFrameProcessorFactory(new DefaultVideoFrameProcessor.Factory.Builder().build());
   }
 }