Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaSessionConnector - metadata for Samsung #4292

Closed
izderadicka opened this issue May 23, 2018 · 1 comment
Closed

MediaSessionConnector - metadata for Samsung #4292

izderadicka opened this issue May 23, 2018 · 1 comment

Comments

@izderadicka
Copy link

Issue description

I use TimelineQueueNavigator with my media application on Samsung phones.
Queue get MediaDescriptionCompat from queue and maps it to MediaMetadataCompat which is then set in MediaSession.
The main infomartion about media item is its title - now comes interesting part - connector maps description title into MEDIA_KEY_DISPLAY_TITLE key, but Samsung (in lock and AOD screens) does not care about this key it but looks only for MEDIA_KEY_TITLE key.
So on Samsung phone I see "Unknown" on AOD and lock screen when my MediaSession is active.

Solution would be to set both MEDIA_KEY_DISPLAY_TITLE and MEDIA_KEY_TITLE in updateMediaSessionMetadata method to fix this Samsung issue ( theoretically its their problem, but they are still big player and it's probably fair to expect MEDIA_KEY_TITLE to be always present and use the other one as an alternative)

I hope my description is not too confusing otherwise please let me know and I can provide some more details.

Reproduction steps

Use app in Samsung

Set to use Lock screen - e.g. lock at least to swipe

Look on Lock Screen or AOD screen media controls

Version of ExoPlayer being used

master

Device(s) and version(s) of Android being used

Samsung specific - N and O versions

@DKillWorld
Copy link

This happenes on certain more devices I tested with. Certainly needs some quick fix.

@ojw28 ojw28 added the bug label May 29, 2018
ojw28 pushed a commit that referenced this issue Jun 6, 2018
Issue: #4292

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=199478946
@ojw28 ojw28 closed this as completed Jun 6, 2018
ojw28 pushed a commit that referenced this issue Jun 6, 2018
Issue: #4292

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=199478946
@google google locked and limited conversation to collaborators Nov 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants