Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple CC tracks support in DASH #5656

Closed
michal-dcc opened this issue Mar 20, 2019 · 4 comments
Closed

Multiple CC tracks support in DASH #5656

michal-dcc opened this issue Mar 20, 2019 · 4 comments
Assignees

Comments

@michal-dcc
Copy link

[REQUIRED] Use case description

We want to be able to select any CC track defined in Accessibility tag.
See dash manifest: https://vm2.dashif.org/dash/vod/testpic_2s/cea608.mpd

We can only check if any CC track is present in the stream. ExoPlayer uses only the first one language track from "value" attribute of the tag which defines CC tracks (parseCea608AccessibilityChannel function).

The value attribute from CC accessibility tag can be retrieved from DASH manifest object that comes in onTimelineChanged event. However, there is no possibility to choose other track than the one that ExoPlayer has chosen.

Proposed solution

(none)

Alternatives considered

n/a

@tonihei
Copy link
Collaborator

tonihei commented Mar 20, 2019

@ojw28 Can you comment on how this is supposed to work and if and what we should do for such a manifest?

@kfrydel
Copy link

kfrydel commented Mar 26, 2019

Hi all,
http://reference.dashif.org/dash.js/v2.6.7/samples/dash-if-reference-player/index.html shows that both CC languages can be selected for the manifest: eng and swe and they are displayed fine.

@ojw28
Copy link
Contributor

ojw28 commented Mar 26, 2019

We would need to add support for this in DashMediaPeriod.

In particular identifyEmbeddedTracks will need to use more than just a boolean to indicate whether a track has an embedded 608 track. buildPrimaryAndEmbeddedTrackGroupInfos will then need to build tracks for each of the embedded tracks, setting the format's accessibilityChannel to the correct value in each case. (e.g. 1 and 3 in this example).

ojw28 added a commit that referenced this issue Apr 1, 2019
Issue: #5656
PiperOrigin-RevId: 241235377
@ojw28
Copy link
Contributor

ojw28 commented Apr 5, 2019

This is supported in the dev-v2 branch (it'll be in the 2.10 release).

@ojw28 ojw28 closed this as completed Apr 5, 2019
@google google locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants